Add C# SDK to nix dev shell#1559
Conversation
Coverage Report for CI Build 25996995172Coverage remained the same at 85.297%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
spacebear21
left a comment
There was a problem hiding this comment.
concept ACK but @nothingmuch brought up out of band that dotnet-sdk_8 is considered insecure and furthermore we should set DOTNET_CLI_TELEMETRY_OPTOUT in the devshell in dotnet-sdk_10
I see, considering making dotnet-sdk_10 the default, the case for dotnet-sdk_8 was compatibility, hopefully 8 has faded out |
Provide .NET 10 SDK tooling in the default nix development shell while keeping the .NET 8 runtime available for the current net8.0 C# tests. Opt out of dotnet CLI telemetry and document the nix command that generates bindings and runs the C# test suite.
5ac6355 to
6489349
Compare
|
Updated this to use SDK 10 tooling while preserving the current I kept the project target on |
|
After some diggin into this a bit more. BTCPay’s .NET 10 floor appears to be BTCPay Server 2.3.7: their 2.3.7 release notes say it is the first release using .NET 10, and their migration guide tells plugin authors moving to So I'm opting to have net 10 but still have net 8 compatibility |
Agents and contributors using nix could not run the C# binding tests because
dotnetwas not provided by the dev shell. The C# test script generates bindings and then runsdotnet test, so nix should provide the SDK used by the repo.Closes #1555
Validation
nix --extra-experimental-features "nix-command flakes" fmt -- --cinix --extra-experimental-features "nix-command flakes" develop -c bash payjoin-ffi/csharp/contrib/test.shDisclosure: co-authored by Codex